[code_assets] Support custom target `OS` and `Architecture` by dcharkes · Pull Request #3413 · dart-lang/native

dcharkes · 2026-06-08T13:10:01Z

Closes: #3411

Closes: #1258

Enables

extension OhosOS on OS {
  static final ohos = OS.fromString('ohos');
}

to work properly.

The other open enums in the JSON schema that were not open in the Dart API:

architecture
sanitizer

Link mode and link mode preference should be closed:

[code_assets] Make LinkMode and LinkModePreference closed #3462

If we were to add code assets already presigned and prepackaged in xcodeframeworks for example, it would be a new asset type, rather than new option for the existing asset type.

Because we don't have a pub workspace for FFIgen and JNIgen with the other packages, we now need many more pubspec overrides. Basically before it was kinda working without a complete set of overrides because the inconsistent set of deps (half from the repo, half from pub) managed to resolve. This is no longer true with pushing code_assets to v2.0.0.

github-actions · 2026-06-08T13:12:15Z

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbol	Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?
hooks_runner	Non-Breaking	1.6.1	1.6.2-wip	1.6.2-wip	✔️
code_assets	Non-Breaking	1.2.1	2.0.0-wip	2.0.0-wip	✔️
objective_c	Breaking	9.5.0	9.5.1-wip	9.5.1-wip	✔️
hooks	Breaking	2.1.0	2.2.0-wip	2.2.0-wip	✔️
native_toolchain_c	Non-Breaking	0.19.3	0.19.4-wip	0.19.4-wip	✔️

This check can be disabled by tagging the PR with skip-breaking-check.

github-actions · 2026-06-09T06:48:31Z

Package publishing

If you have publishing permissions, you can use the links below to publish the changes after merging this PR.

Package	Version	Status	Publish tag (post-merge)
package:code_assets	2.0.0	ready to publish	`code_assets-v2.0.0`
package:data_assets	0.20.0	already published at pub.dev
package:ffi	2.2.0	already published at pub.dev
package:hooks	2.0.2	already published at pub.dev
package:hooks_runner	1.6.0-wip	WIP (no publish necessary)
package:jni_flutter	1.0.1	already published at pub.dev
package:jni_util	1.0.0-wip	WIP (no publish necessary)
package:native_toolchain_c	0.19.3-wip	WIP (no publish necessary)
package:record_use	0.6.1-wip	WIP (no publish necessary)
package:swift2objc	0.2.0	already published at pub.dev
package:swiftgen	0.1.3-wip	WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

dcharkes · 2026-06-10T10:52:16Z

@goderbauer I'm not entirely sure what to do with link mode preference and link mode:

Extensibility of link mode is somewhat problematic, because it's likely more than a string. And it's not namespaced with a package. So different third_parties (or us) might not agree on what fields the link mode should have.
Introducing new link modes is also problematic, because we don't communicate in the protocol which link modes are supported yes or no. So a packages' link hook doesn't know if they emit something in a specific link mode.
And introducing link mode preferences will not work either.

If we decide to lock it down, then the way to add something later from our side would be to make a new asset type package:code_assets/code_asset_v2. And have new link modes there.

And I can't think of a link mode we would add in the first place.

WDYT about locking it down instead of making it extensible?

goderbauer · 2026-07-08T12:09:21Z

WDYT about locking it down instead of making it extensible?

Yeah, given that it is highly questionable that we'll ever add another mode (famous last words): Let's lock it down.

dcharkes · 2026-07-09T10:37:36Z

Unrelated CI failures:

dcharkes · 2026-07-09T10:47:45Z

WDYT about locking it down instead of making it extensible?

Yeah, given that it is highly questionable that we'll ever add another mode (famous last words): Let's lock it down.

Made a separate PR for this:

[code_assets] Make LinkMode and LinkModePreference closed #3462

goderbauer

LGTM

Makes the link mode and link mode preference closed enums / a closed tagged union. #3413 (comment) Code assets changes: * Changes the JSON schema to a closed enum for link mode preference and closed tagged union for link mode. * So encountering an unknown value in a json is now a parse error. * And will print a more elaborate error message. * Sealed the `LinkMode` class. * Skipping a version bump, we'll bump to 2.0 in the next PR due to breaking changes. JSON syntax generator changes: * Updated closed enum generation to pass valid enum values to `_throwFormatException`. * Updated closed tagged union generationto pass valid discriminator tag values to `_throwFormatException`. * Added `Set<String>? expectedValues` parameter to `throwFormatException` and `errorString` to format error messages as `Expected one of 'a', 'b'`. * Made `expectedType` an optional named parameter on `throwFormatException` and `errorString` in `helper_library.dart`. * Added a json path to the constructor for enums to be able to give the json path in the error message. Other package changes: * Update all the generated syntax (no functional change as they have no closed enums).

dcharkes requested a review from goderbauer June 8, 2026 13:10

github-actions Bot added package:hooks package:native_toolchain_c package:hooks_runner package:ffigen package:objective_c package:code_assets labels Jun 8, 2026

dcharkes force-pushed the code-assets-custom-os branch from c57aaef to 5faa75d Compare June 9, 2026 06:42

github-actions Bot added the package:swiftgen label Jun 9, 2026

dcharkes force-pushed the code-assets-custom-os branch 2 times, most recently from 0dfe2f3 to 27eeaef Compare June 9, 2026 07:39

github-actions Bot added the package:jni label Jun 9, 2026

dcharkes force-pushed the code-assets-custom-os branch from 27eeaef to 4d6c36c Compare June 9, 2026 16:22

goderbauer reviewed Jun 10, 2026

View reviewed changes

Comment thread pkgs/code_assets/CHANGELOG.md Outdated

Comment thread pkgs/ffigen/example/c_json/pubspec.yaml Outdated

Comment thread tool/ci.dart

dcharkes force-pushed the code-assets-custom-os branch from 4d6c36c to 4b771f3 Compare June 10, 2026 09:16

github-actions Bot added the package:jnigen label Jun 10, 2026

dcharkes added the skip-changelog-check label Jun 10, 2026

dcharkes requested a review from goderbauer June 22, 2026 06:54

dcharkes mentioned this pull request Jul 9, 2026

[code_assets] Make LinkMode and LinkModePreference closed #3462

Merged

dcharkes force-pushed the code-assets-custom-os branch from 128f9fb to de8fd8a Compare July 9, 2026 09:32

github-actions Bot added the package:data_assets label Jul 9, 2026

dcharkes force-pushed the code-assets-custom-os branch from de8fd8a to 23dc6db Compare July 9, 2026 09:37

github-actions Bot removed the package:jni label Jul 9, 2026

dcharkes force-pushed the code-assets-custom-os branch from 23dc6db to 761c686 Compare July 9, 2026 10:43

github-actions Bot removed the package:jnigen label Jul 9, 2026

dcharkes force-pushed the code-assets-custom-os branch from 761c686 to 6ce683f Compare July 10, 2026 07:32

dcharkes changed the base branch from main to code-assets-close-link-mode July 10, 2026 07:32

dcharkes force-pushed the code-assets-close-link-mode branch from fa60898 to 0a837af Compare July 10, 2026 07:33

dcharkes force-pushed the code-assets-custom-os branch from 6ce683f to 009567e Compare July 10, 2026 07:39

github-actions Bot removed the package:data_assets label Jul 10, 2026

dcharkes force-pushed the code-assets-custom-os branch from 009567e to 4f941ad Compare July 10, 2026 07:53

goderbauer approved these changes Jul 10, 2026

View reviewed changes

dcharkes mentioned this pull request Jul 10, 2026

[record_use] [hooks] [hooks_runner] [native_toolchain_c] Release versions #3471

Merged

dcharkes mentioned this pull request Jul 21, 2026

[code_assets] Validate dynamic library architecture from file headers #3484

Merged

6 tasks

dcharkes mentioned this pull request Aug 10, 2026

feat(code_assets): add ohos OS support for OpenHarmony/HarmonyOS NEXT #3409

Closed

dcharkes force-pushed the code-assets-close-link-mode branch from 0a837af to 3b33741 Compare August 10, 2026 12:59

dcharkes force-pushed the code-assets-custom-os branch from 4f941ad to 898be11 Compare August 10, 2026 12:59

Base automatically changed from code-assets-close-link-mode to main August 10, 2026 13:18

[code_assets] Support custom target OS and Architecture

80bc5bd

dcharkes force-pushed the code-assets-custom-os branch from 898be11 to 80bc5bd Compare August 10, 2026 14:39

dcharkes added 2 commits August 10, 2026 16:43

[code_assets] Make LinkModePreference const-compatible

ab1cb64

[objective_c] Add meta override to example Flutter projects

b32ae30

dcharkes merged commit b030dc8 into main Aug 10, 2026
52 checks passed

dcharkes deleted the code-assets-custom-os branch August 10, 2026 15:16

Navigation Menu

Uh oh!

[code_assets] Support custom target `OS` and `Architecture` - #3413

[code_assets] Support custom target `OS` and `Architecture`#3413
dcharkes merged 3 commits into
mainfrom
code-assets-custom-os

dcharkes commented Jun 8, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 8, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dcharkes commented Jun 10, 2026

Uh oh!

goderbauer commented Jul 8, 2026

Uh oh!

dcharkes commented Jul 9, 2026

Uh oh!

dcharkes commented Jul 9, 2026

Uh oh!

goderbauer left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dcharkes commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Health

Uh oh!

github-actions Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package publishing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dcharkes commented Jun 10, 2026

Uh oh!

goderbauer commented Jul 8, 2026

Uh oh!

dcharkes commented Jul 9, 2026

Uh oh!

dcharkes commented Jul 9, 2026

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dcharkes commented Jun 8, 2026 •

edited

Loading

github-actions Bot commented Jun 8, 2026 •

edited

Loading

github-actions Bot commented Jun 9, 2026 •

edited

Loading